Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.1: db-console: Update absolute links to relative links #73122

Merged

Conversation

rimadeodhar
Copy link
Collaborator

@rimadeodhar rimadeodhar commented Nov 24, 2021

Backport 1/1 commits from #72837.

/cc @cockroachdb/release


This PR updates the absolute links on the
Advanced Debug page of DB Console to
relative links. This change will allow these
links to work correctly even when DB Console
is accessed through the superuser dashboard.

Absolute links currently don't work with the
SU dashboard as the SU dashboard connection
to DB Console is proxied through intrusion.

Release note (ui change): The absolute links on the Advanced
Debug page within DB Console have been updated to relative
links. This will enable these links to work with the
superuser dashboard in Cloud Console.

Release justification: Bug fix to ensure compatibility with SU DB Console.

@blathers-crl
Copy link

blathers-crl bot commented Nov 24, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

This PR updates the absolute links on the
Advanced Debug page of DB Console to
relative links. This change will allow these
links to work correctly even when DB Console
is accessed through the superuser dashboard.

Absolute links currently don't work with the
SU dashboard as the SU dashboard connection
to DB Console is proxied through intrusion.

Release note (ui change): The absolute links on the Advanced
Debug page within DB Console have been updated to relative
links. This will enable these links to work with the
superuser dashboard in Cloud Console.
@rimadeodhar rimadeodhar requested review from dhartunian and a team November 24, 2021 17:34
@rimadeodhar rimadeodhar marked this pull request as ready for review November 24, 2021 17:36
@rimadeodhar rimadeodhar merged commit 3525f2a into cockroachdb:release-21.1 Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants