-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-21.2: ui: fix index count on Database Details Page indexes column #73747
Conversation
Resolves #72655 Previously, the index count on the Database Details page was misleading because it referred to the total number of columns that contained an index rather than the number of indexes. This commit fixes that issue by counting the unique index names returned in the API response rather than the total length of the indexes array. Release note (bug fix): use correct index count on the indexes column on the Database Details page
e019f3b
to
df58efb
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @lindseyjin and @maryliag)
@lindseyjin make sure to add the Release justification and mark the appropriate checkboxes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
This commit removes a TODO that was partially addressed by cockroachdb#82022. Informs cockroachdb#73747 Release note: None
Backport 1/1 commits from #73703 on behalf of @lindseyjin.
/cc @cockroachdb/release
Resolves #72655
Previously, the index count on the Database Details page was misleading
because it referred to the total number of columns that contained an
index rather than the number of indexes. This commit fixes that issue by
counting the unique index names returned in the API response rather than
the total length of the indexes array.
Release note (bug fix): use correct index count on the indexes column on
the Database Details page
Release justification: Category 2