Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: ui: fix index count on Database Details Page indexes column #73747

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 13, 2021

Backport 1/1 commits from #73703 on behalf of @lindseyjin.

/cc @cockroachdb/release


Resolves #72655

Previously, the index count on the Database Details page was misleading
because it referred to the total number of columns that contained an
index rather than the number of indexes. This commit fixes that issue by
counting the unique index names returned in the API response rather than
the total length of the indexes array.

Release note (bug fix): use correct index count on the indexes column on
the Database Details page


Release justification: Category 2

Resolves #72655

Previously, the index count on the Database Details page was misleading
because it referred to the total number of columns that contained an
index rather than the number of indexes. This commit fixes that issue by
counting the unique index names returned in the API response rather than
the total length of the indexes array.

Release note (bug fix): use correct index count on the indexes column on
the Database Details page
@blathers-crl
Copy link
Author

blathers-crl bot commented Dec 13, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 13, 2021
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@matthewtodd matthewtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @lindseyjin and @maryliag)

@maryliag
Copy link
Contributor

@lindseyjin make sure to add the Release justification and mark the appropriate checkboxes

Copy link
Contributor

@lindseyjin lindseyjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)

@lindseyjin lindseyjin merged commit 30572d1 into release-21.2 Dec 13, 2021
@lindseyjin lindseyjin deleted the blathers/backport-release-21.2-73703 branch December 13, 2021 20:11
mgartner added a commit to mgartner/cockroach that referenced this pull request Jun 28, 2023
This commit removes a TODO that was partially addressed by cockroachdb#82022.

Informs cockroachdb#73747

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants