sql: support RULE privilege for compatibility #73960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
approved these changes
Dec 17, 2021
rafiss
commented
Dec 17, 2021
| ---- | ||
| true true true true true true true true true | ||
| true true true true true true true true true true |
There was a problem hiding this comment.
i'm still thinking about this -- some of these return true for RULE because the user has ALL privileges. i'm wondering if we should special-case RULE in the has_table_privilege implementation so it just always returns false.
There was a problem hiding this comment.
i changed it to always return false
The RULE privilege is legacy in Postgres, but some tools expect the has_table_privilege function to work. Release note (sql change): The RULE privilege was added for compatbility with Postgres. It is impossible to grant it, but it is supported as a parameter of the has_table_privilege function.
rafiss
force-pushed
the
add-rule-priv
branch
from
4625fab
to
95c3716
Compare
|
I would do what postgres doesin the ALL case. I understand the argument both ways but I guess when I come back to is that if we're following pg compat then we should match pg. |
|
tftr! merging after unrelated flake bors r=otan |
|
Build succeeded: |
|
can this be backported to 21.2? it would unblock a customer who's trying to use a tool that relies on this, but not sure how risky it is |
|
don't see why not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #72832
The RULE privilege is legacy in Postgres, but some tools expect
the has_table_privilege function to work.
Release note (sql change): The RULE privilege was added for compatbility
with Postgres. It is impossible to grant it, but it is supported as a
parameter of the has_table_privilege function.