kv: rename gcQueue to mvccGCQueue #74109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nvanbenschoten
force-pushed
the
nvanbenschoten/mvccGCQueue
branch
from
3c36649
to
c2c0847
Compare
nvanbenschoten
requested review from
a team and
dt
and removed request for
a team and
dt
Split out from next commit to avoid confusing git.
nvanbenschoten
force-pushed
the
nvanbenschoten/mvccGCQueue
branch
from
c2c0847
to
c0255f9
Compare
tbg
approved these changes
Dec 21, 2021
This commit renames the "GC queue" to the "MVCC GC queue" (which GC's old MVCC versions) to avoid confusion with the "replica GC queue" (which GC's abandoned replicas). We've already been using this terminology in various other contexts to avoid confusion, so this refactor updates the code to reflect this naming. This comes in response to cockroachdb#73838, which found a bug that had survived for three years and was a direct consequence of this ambiguous naming. The commit doesn't go quite as far as renaming the `pkg/kv/kvserver/gc` package, but that could be a follow-up to this commit.
nvanbenschoten
force-pushed
the
nvanbenschoten/mvccGCQueue
branch
from
c0255f9
to
ebf9977
Compare
|
TFTR! bors r=tbg |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames the "GC queue" to the "MVCC GC queue" (which GC's old MVCC
versions) to avoid confusion with the "replica GC queue" (which GC's abandoned
replicas). We've already been using this terminology in various other contexts
to avoid confusion, so this refactor updates the code to reflect this naming.
This comes in response to #73838, which found a bug that had survived for three
years and was a direct consequence of this ambiguous naming.
The commit doesn't go quite as far as renaming the
pkg/kv/kvserver/gcpackage,but that could be a follow-up to this commit.