cockroach: don't import randgen in binary #74128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
5 tasks
otan
approved these changes
Dec 21, 2021
dt
approved these changes
Dec 21, 2021
|
TFTRs! bors r+ |
|
bors r- |
|
Canceled. |
The `sql/randgen` package creates a lot of global datums, some of which use geospatial and require the loading of geospatial data. This package is meant for testing and should not be part of the cockroach binary. This change removes the non-testing uses of randgen. Tested via `go list -deps ./pkg/cmd/cockroach`. Note that the updated test is ineffectual for now (tracked by cockroachdb#74119). Informs cockroachdb#74120. Release note: None
RaduBerinde
force-pushed
the
remove-randgen-from-binary
branch
from
a958de7
to
744c7ed
Compare
|
bors r+ |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sql/randgenpackage creates a lot of global datums, some ofwhich use geospatial and require the loading of geospatial data. This
package is meant for testing and should not be part of the cockroach
binary.
This change removes the non-testing uses of randgen.
Tested via
go list -deps ./pkg/cmd/cockroach. Note that the updatedtest is ineffectual for now (tracked by #74119).
Informs #74120.
Release note: None