Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanconfig: set stage for migration #74266

Merged
merged 4 commits into from
Jan 14, 2022
Merged

spanconfig: set stage for migration #74266

merged 4 commits into from
Jan 14, 2022

Commits on Jan 13, 2022

  1. clusterversion: improve a version comment 

    Gets rid of a squiggly line in Goland.

Release note: None
    @irfansharif
    irfansharif committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    105c496 View commit details
    Browse the repository at this point in the history

  2. kvserver: plumb in a context into (*Store).GetConfReader 

    We'll use it in a future commit.

Release note: None
    @irfansharif
    irfansharif committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    120e74e View commit details
    Browse the repository at this point in the history

  3. spanconfig/reconciler: export the checkpoint timestamp 

    We'll make use of it in a future commit.

Release note: None
    @irfansharif
    irfansharif committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    ab6c601 View commit details
    Browse the repository at this point in the history

  4. spanconfig: get rid of ReconciliationDependencies interface 

    It was hollow, simply embedding the spanconfig.Reconciler interface. In
a future commit we end up relying on each pod's span config reconciler
outside of just the reconciliation job. This makes the interface even
awkwarder than it was.

Release note: None
    @irfansharif
    irfansharif committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    5d7f4d3 View commit details
    Browse the repository at this point in the history