Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: support default default_table_access_method var value #74774

Merged

Conversation

otan
Copy link
Contributor

@otan otan commented Jan 13, 2022

Release note (sql change): Support the default_table_access_method
session variable, which only takes in heap (same as PG).

Release note (sql change): Support the `default_table_access_method`
session variable, which only takes in `heap` (same as PG).
@otan otan requested a review from rafiss January 13, 2022 00:02
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, i wonder what "heap" even means. the one concern is just if it means something specific that we don't actually implement.

@otan
Copy link
Contributor Author

otan commented Jan 13, 2022

not sure, it is the default and based on https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=8586bf7ed8889f39a59dd99b292014b73be85342 and the lack of docs available it's uh not implemented fully? seems safe to do the default though.

@otan otan requested a review from rafiss January 20, 2022 06:07
@otan
Copy link
Contributor Author

otan commented Jan 20, 2022

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Jan 20, 2022

Build failed:

@otan
Copy link
Contributor Author

otan commented Jan 20, 2022

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Jan 20, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants