cli: force quit when draining fails #7483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
tbg
force-pushed
the
cli-quit
branch
2 times, most recently
from
69f6ec2
to
3448d74
Compare
``` $ ./cockroach quit graceful shutdown failed, proceeding with hard shutdown: rpc error: code = 2 desc = replica range=1 [/Min-/Table/11) still has an active lease ok ``` Fixes cockroachdb#6963.
|
PTAL again, added another commit which makes the behavior better for the use case in #6963. |
When the cluster is dead (for example due to loss of quorum), an in-flight leader lease request (which was stuck) would prevent clean shutdown indefinitely. The added check on the inflight request lease's expiration makes sure that we still exit gracefully after the request has been stuck for a bit.
|
seems good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6963.
This change is