*: always call Close() on http.Response.Body #75136
Conversation
|
This change is |
knz
force-pushed
the
20220119-body-close
branch
from
89ae0be
to
b656f78
Compare
Since go 1.17.6, forgetting to call Close() results in goroutine leaks. Release note: None
knz
force-pushed
the
20220119-body-close
branch
from
b656f78
to
38c4a20
Compare
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @knz and @stevendanna)
pkg/server/server_test.go, line 272 at r1 (raw file):
According to:
If the returned error is nil, the Response will contain a non-nil Body which the user is expected to close.
Should we only close the body after checking err is nil below?
There was a problem hiding this comment.
Reviewable status:
pkg/server/server_test.go, line 272 at r1 (raw file):
Previously, Azhng (Archer Zhang) wrote…
According to:
If the returned error is nil, the Response will contain a non-nil Body which the user is expected to close.
Should we only close the body after checking
erris nil below?
Actually nvm, the err comes from the io.Copy
|
TFYR! bors r=Azhng |
|
Build failed (retrying...): |
|
Build succeeded: |
Since go 1.17.6, forgetting to call Close() results in goroutine
leaks.
See: golang/go#50652
Release note: None