Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: "skip" TestChangefeedRestartDuringBackfill.. #75146

Merged
merged 1 commit into from
Jan 19, 2022
Merged

backupccl: "skip" TestChangefeedRestartDuringBackfill.. #75146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions pkg/ccl/changefeedccl/changefeed_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,12 +394,12 @@ func TestChangefeedFullTableName(t *testing.T) {
assertPayloads(t, foo, []string{`d.public.foo: [1]->{"after": {"a": 1, "b": "a"}}`})
})
}
//TODO(zinger): Plumb this option through to all encoders so it works in sinkless mode
//t.Run(`sinkless`, sinklessTest(testFn))
// TODO(zinger): Plumb this option through to all encoders so it works in sinkless mode
// t.Run(`sinkless`, sinklessTest(testFn))
t.Run(`enterprise`, enterpriseTest(testFn))
t.Run(`kafka`, kafkaTest(testFn))
t.Run(`webhook`, webhookTest(testFn))
//t.Run(`pubsub`, pubsubTest(testFn))
// t.Run(`pubsub`, pubsubTest(testFn))
}

func TestChangefeedMultiTable(t *testing.T) {
Expand Down Expand Up @@ -2417,7 +2417,7 @@ func TestChangefeedTruncateOrDrop(t *testing.T) {
t.Run(`kafka`, kafkaTest(testFn))
t.Run(`webhook`, webhookTest(testFn))
t.Run(`pubsub`, pubsubTest(testFn))
//will sometimes fail, non deterministic
// will sometimes fail, non deterministic
}

func TestChangefeedMonitoring(t *testing.T) {
Expand Down Expand Up @@ -4102,7 +4102,15 @@ func TestChangefeedRestartDuringBackfill(t *testing.T) {
})
}

t.Run(`kafka`, kafkaTest(testFn))
useSysCfgInKV := withKnobsFn(func(knobs *base.TestingKnobs) {
// TODO(irfansharif): This test is "skipped" under span configs;
// #75080.
if knobs.Store == nil {
knobs.Store = &kvserver.StoreTestingKnobs{}
}
knobs.Store.(*kvserver.StoreTestingKnobs).UseSystemConfigSpanForQueues = true
})
t.Run(`kafka`, kafkaTest(testFn, useSysCfgInKV))
}

func TestChangefeedHandlesDrainingNodes(t *testing.T) {
Expand Down