-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
randgen: do not create computed columns with bad volatilities #75161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Reviewable status:
complete! 0 of 0 LGTMs obtained
Some cast to STRING types has been given an incorrect volatility. For example, REGCLASS->STRING casts are immutable when they should be stable (see cockroachdb#74286 and cockroachdb#74553 for more details). Creating computed column expressions with such a cast can cause logical correctness bugs and internal errors. The volatilities cannot be fixed without causing backward incompatibility. This commit prevents `randgen` from creating computed columns with these casts so that sqlsmith and TLP do not repetitively find these known volatility bugs. Release note: None
38c78be
to
8b5f53c
Compare
TFTR! bors r+ |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 8b5f53c to blathers/backport-release-21.1-75161: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.1.x failed. See errors above. error creating merge commit from 8b5f53c to blathers/backport-release-21.2-75161: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Some cast to STRING types has been given an incorrect volatility. For
example, REGCLASS->STRING casts are immutable when they should be stable
(see #74286 and #74553 for more details).
Creating computed column expressions with such a cast can cause logical
correctness bugs and internal errors. The volatilities cannot be fixed
without causing backward incompatibility. This commit prevents
randgen
from creating computed columns with these casts so that sqlsmith and TLP
do not repetitively find these known volatility bugs.
Informs #74727
Release note: None