kv: fix GenerateForcedRetryableError to return a bumped epoch #75165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for PR cockroachdb#74563, where we change how txn is reset. Without this change GenerateForcedRetryableError returns an error with an inner txn that has an epoch 0. With this change the epoch is copied from the original txn. Release note: None
|
This change is |
nvanbenschoten
approved these changes
Jan 19, 2022
|
thanks! |
craig bot
pushed a commit
that referenced
this pull request
Jan 19, 2022
73062: physicalplan: add support for multi-stage execution of covar_pop. r=yuzefovich a=mneverov physicalplan: add support for multi-stage execution of covar_pop. See #58347. Release note (performance improvement): `covar_pop` aggregate function is now evaluated more efficiently in a distributed setting. 75148: sql/rowenc: avoid panic when encoding delete preserving index r=rhu713 a=stevendanna It appears, we can occasionally be asked to encode empty KVs. Notably, this seems to happen along the delete path when multiple column families are in play. The included test case mirrors the case that caught this bug on an in-progress branch. Namely, a "temporary" index used by the new index backfiller during a primary key change. Release note: None 75160: build: add utility function to merge test xml's r=rail a=rickystewart The `stress` utility runs tests many times to accumulate results, so we'd like some code to merge multiple `test.xml` files into a single one. Release note: None 75165: kv: fix GenerateForcedRetryableError to return a bumped epoch r=lidorcarmel a=lidorcarmel This is needed for PR #74563, where we change how txn is reset. Without this change GenerateForcedRetryableError returns an error with an inner txn that has an epoch 0. With this change the epoch is copied from the original txn. Release note: None 75169: vendor: pull in latest version of `stress` r=rail a=rickystewart Pull in the latest version of `stress` including these changes: ``` 43d99a9 Merge pull request #13 from cockroachdb/bazelsharding 01690a1 stress: add `-bazel` support, support for sharding artifacts ``` Release note: None Co-authored-by: Max Neverov <neverov.max@gmail.com> Co-authored-by: Steven Danna <danna@cockroachlabs.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com> Co-authored-by: Lidor Carmel <lidor@cockroachlabs.com>
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for PR #74563, where we change how txn is reset.
Without this change GenerateForcedRetryableError returns an
error with an inner txn that has an epoch 0. With this change
the epoch is copied from the original txn.
Release note: None