changefeedccl: more redactions in changefeed job description #75174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
|
HonoreDB
force-pushed
the
redacted_description
branch
from
640004a
to
6d95164
Compare
Expands the denylist for what in the sink URI gets shown in the job description to redact ca_cert and client_cert. Also redacts everything before an `@` symbol in the host as that can be a user credential. Release note (enterprise change): Redacted more potentially-sensitive URI elements from changefeed job descriptions. This is a breaking change for workflows involving copying URIs. As an alternative, the unredacted URI may be accessed from the jobs table directly.
HonoreDB
force-pushed
the
redacted_description
branch
from
6d95164
to
4852af4
Compare
dt
approved these changes
Jan 19, 2022
|
bors r=[dt] |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the denylist for what in the sink URI gets shown in the
job description to redact ca_cert and client_cert.
Also redacts everything before an
@symbol in the host as thatcan be a user credential.
Release note (enterprise change): Redacted more potentially-sensitive URI elements from changefeed job descriptions. This is a breaking change for workflows involving copying URIs. As an alternative, the unredacted URI may be accessed from the jobs table directly.