ptverifier: delete the protected timestamp Verifier #75883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
23 tasks
Release note: None Release justification: low risk change to existing functionality
adityamaru
force-pushed
the
remove-verify
branch
2 times, most recently
from
8c31364
to
62b57d0
Compare
adityamaru
requested review from
stevendanna,
arulajmani and
a team
and removed request for
a team
Release note: None Release justification: low risk change to existing functionality
|
|
Verification semantics are not supported in the new multi-tenant protected timestamp subsystem. For details about why this is the case please refer to the `Verification` section in the RFC at cockroachdb#74685. This change deletes the Verifier, and all references of it. Informs: cockroachdb#73727 Release note: None Release justification: low risk change to existing functionality
adityamaru
force-pushed
the
remove-verify
branch
from
62b57d0
to
366c3e8
Compare
arulajmani
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Third commit
Reviewed 1 of 1 files at r1, 3 of 3 files at r2, 9 of 9 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (and 1 stale) (waiting on @stevendanna)
|
TFTRs! bors r=miretskiy,arulajmani |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification semantics are not supported in the new multi-tenant
protected timestamp subsystem. For details please refer to the
Verificationsection in theRFC at #74685.
This change deletes the Verifier, and all references of it.
Informs: #73727
Release note: None
Release justification: low risk change to existing functionality