Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeed: fix schema backfill after initial scan checkpoint #77797

Conversation

samiskin
Copy link
Contributor

A changefeed that was restarted during a backfill with a checkpoint laid
down would neglect to clear the checkpoint information from aggregator
nodes, causing future backfills triggered by schema changes to reuse the
old checkpoint and skip spans.

This patch clears the kvFeed's checkpoint data upon scan completion

Release justification: low risk bug fix
Release note (bug fix): fix successive schema change backfills from
skipping spans that were checkpointed by an initial backfill that was
restarted

@samiskin samiskin requested a review from miretskiy March 14, 2022 21:20
@samiskin samiskin requested a review from a team as a code owner March 14, 2022 21:20
@cockroach-teamcity
Copy link
Member

This change is Reviewable

A changefeed that was restarted during a backfill with a checkpoint laid
down would neglect to clear the checkpoint information from aggregator
nodes, causing future backfills triggered by schema changes to reuse the
old checkpoint and skip spans.

This patch clears the kvFeed's checkpoint data upon scan completion

Release justification: low risk bug fix
Release note (bug fix): fix successive schema change backfills from
skipping spans that were checkpointed by an initial backfill that was
restarted
@samiskin samiskin force-pushed the fix-changefeed-schema-backfill-after-initial-checkpoint branch from 0d2a6bb to d70a2de Compare March 14, 2022 23:31
@samiskin
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 15, 2022

Build succeeded:

@craig craig bot merged commit f5fc84f into cockroachdb:master Mar 15, 2022
@blathers-crl
Copy link

blathers-crl bot commented Mar 15, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating backport branch refs/heads/blathers/backport-release-21.2-77797: POST https://api.github.com/repos/cockroachlabs/cockroach/git/refs: 403 Resource not accessible by integration []

Backport to branch 21.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants