Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: jobs: fix startable job num-runs overcount #79051

Merged
merged 1 commit into from Apr 1, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 30, 2022

Backport 1/1 commits from #77240 on behalf of @samiskin.

/cc @cockroachdb/release


Release justification: low risk bug fix

Removes extra call to started() in StartableJob's Start since its
already called in stepThroughStateMachine later on

Release note (bug fix): fix num_runs being incremented twice for certain
jobs upon being started


Release justification:

@blathers-crl blathers-crl bot requested review from a team, ajwerner and miretskiy March 30, 2022 16:45
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 30, 2022
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 30, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Release justification: low risk bug fix

Removes extra call to started() in StartableJob's Start since its
already called in stepThroughStateMachine later on

Release note (bug fix): fix num_runs being incremented twice for certain
jobs upon being started
@samiskin samiskin force-pushed the blathers/backport-release-21.2-77240 branch from 30fc929 to 0a65ec2 Compare March 31, 2022 20:56
@samiskin samiskin merged commit bc0813f into release-21.2 Apr 1, 2022
@samiskin samiskin deleted the blathers/backport-release-21.2-77240 branch April 1, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants