release-22.1: pkg/util/admission: track history for bytes added per work #79343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #79302 on behalf of @ajwerner.
/cc @cockroachdb/release
Before this patch, when no bytes were admitted in an interval, we'd assume that
the correct estimate per byte was 1. This meant that we could see a huge jump
in tokens which effectively disabled the throttling of admission control.
Backports will address #79214.
Release note (bug fix): Fixed a bug in IO admission control which could result
in admission control failing to rate-limit when traffic was stalled such that
no work was admitted, despite the store's being in an unhealthy state.
Release justification: low-risk, high impact change