Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: pkg/util/admission: track history for bytes added per work #79343

Merged
merged 1 commit into from Apr 4, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 4, 2022

Backport 1/1 commits from #79302 on behalf of @ajwerner.

/cc @cockroachdb/release


Before this patch, when no bytes were admitted in an interval, we'd assume that
the correct estimate per byte was 1. This meant that we could see a huge jump
in tokens which effectively disabled the throttling of admission control.

Backports will address #79214.

Release note (bug fix): Fixed a bug in IO admission control which could result
in admission control failing to rate-limit when traffic was stalled such that
no work was admitted, despite the store's being in an unhealthy state.


Release justification: low-risk, high impact change

Before this patch, when no bytes were admitted in an interval, we'd assume that
the correct estimate per byte was 1. This meant that we could see a huge jump
in tokens which effectively disabled the throttling of admission control.

Release note (bug fix): Fixed a bug in IO admission control which could result
in admission control failing to rate-limit when traffic was stalled such that
no work was admitted, despite the store's being in an unhealthy state.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-79302 branch from a86265c to 59bcd86 Compare April 4, 2022 16:11
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 4, 2022
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 4, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)

@ajwerner
Copy link
Contributor

ajwerner commented Apr 4, 2022

TFTR!

@ajwerner ajwerner merged commit 151698b into release-22.1 Apr 4, 2022
@ajwerner ajwerner deleted the blathers/backport-release-22.1-79302 branch April 4, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants