Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: vendor: bump Pebble to f9d4931a5fd2 #79611

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Apr 7, 2022

f9d4931a compaction: add L0CompactionFileThreshold compaction trigger

Release note (bug fix): Fix a bug where Pebble compaction heuristics
could allow a large compaction backlog to accumulate, eventually
triggering high read amplification.

Release justification: Fixes high severity bug resulting from an interaction
between Pebble compaction heuristics and admission control.

f9d4931a compaction: add L0CompactionFileThreshold compaction trigger

Release note (bug fix): Fix a bug where Pebble compaction heuristics
could allow a large compaction backlog to accumulate, eventually
triggering high read amplfiication.
@jbowens jbowens requested a review from a team April 7, 2022 20:18
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jbowens jbowens changed the title vendor: bump Pebble to f9d4931a5fd2 release-21.2: vendor: bump Pebble to f9d4931a5fd2 Apr 7, 2022
Copy link
Collaborator

@nicktrav nicktrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jbowens)

Copy link
Collaborator Author

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR!

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jbowens)

@jbowens jbowens merged commit d7c5d1c into cockroachdb:release-21.2 Apr 8, 2022
@jbowens jbowens deleted the jackson/pebble-release-21.2-f9d4931a5fd2 branch April 8, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants