Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: sql: fix overflow for soft limits #79924

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented Apr 13, 2022

Backport 1/1 commits from #79865.

/cc @cockroachdb/release


We're tracking LimitHint property as a float and later convert it to
an int64. Previously, this could lead to overflows when the limit hint
value exceeds the range of int64, and we now instead will use a value of
0 (i.e. disable the soft limit).

Fixes: #77578.
Fixes: #79759.

Release note (bug fix): Previously, CockroachDB could encounter an
internal error when evaluating queries with OFFSET and LIMIT clauses
when the addition of the offset and the limit value would be larger
than int64 range.

Release justification: bug fix.

We're tracking `LimitHint` property as a float and later convert it to
an int64. Previously, this could lead to overflows when the limit hint
value exceeds the range of int64, and we now instead will use a value of
0 (i.e. disable the soft limit).

Release note (bug fix): Previously, CockroachDB could encounter an
internal error when evaluating queries with OFFSET and LIMIT clauses
when the addition of the `offset` and the `limit` value would be larger
than `int64` range.
@yuzefovich yuzefovich requested a review from rytaft April 13, 2022 20:47
@yuzefovich yuzefovich requested a review from a team as a code owner April 13, 2022 20:47
@blathers-crl
Copy link

blathers-crl bot commented Apr 13, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rytaft)

@yuzefovich yuzefovich merged commit 4d3e4b4 into cockroachdb:release-21.2 Apr 18, 2022
@yuzefovich yuzefovich deleted the backport21.2-79865 branch April 18, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants