Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: backupccl: Fix SHOW BACKUPS on a bucket's base directory #80510

Merged
merged 1 commit into from Apr 26, 2022

Conversation

benbardin
Copy link
Collaborator

@benbardin benbardin commented Apr 25, 2022

Backport 1/1 commits from #80182.

/cc @cockroachdb/release


Fixes #77930. Tested on GS and AWS.

Release note (enterprise change): Fix bug where backups in the base directory of a cloud storage bucket would not be discovered by SHOW BACKUPS. These backups will now appear correctly.

Release justification: A low-risk bugfix for a user-facing issue.

Release note (enterprise change): Fix bug where backups in the base directory
of a Google Storage bucket would not be discovered by SHOW BACKUPS. These
backups will now appear correctly.

Release justification: A low-risk bugfix for a user-facing issue.
@benbardin benbardin requested review from a team and adityamaru and removed request for a team April 25, 2022 20:41
@blathers-crl
Copy link

blathers-crl bot commented Apr 25, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@benbardin benbardin merged commit 976853d into cockroachdb:release-21.2 Apr 26, 2022
@benbardin benbardin deleted the backport21.2-80182 branch April 26, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants