Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: add revised plan for loosely-coupled truncation #81113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sumeerbhola
Copy link
Collaborator

Release note: None

@sumeerbhola sumeerbhola requested a review from a team as a code owner May 6, 2022 21:27
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@sumeerbhola sumeerbhola removed the request for review from a team May 6, 2022 21:27
// the memtable. This is because of the per-entry overhead. This means
// there is a decent probability that the state machine memtable will
// start getting flushed before the corresponding raft engine memtable
// is flushed. If the flush is fast enough, we would be able to truncate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also "just" run the raft instance with a larger memtable?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my thinking as well. With the separate engines, we should be able to configure it specifically for this use-case -- I'm sure there are other tweaks we could make too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my thinking as well. With the separate engines, we should be able to configure it specifically for this use-case -- I'm sure there are other tweaks we could make too.

@tbg
Copy link
Member

tbg commented May 23, 2022

This can merge, Sumeer.

@sumeerbhola
Copy link
Collaborator Author

This can merge, Sumeer.

I've been running some experiments using sumeerbhola@d186760 to compare the write amp for shared and separated LSMs under both loosely and tightly coupled truncation, in order to understand this better.
I'll report on the results soon, and will merge this sometime after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants