cli: add tests for PGPASSFILE and PGSERVICEFILE #82389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
force-pushed
the
pg-conn-tests
branch
2 times, most recently
from
0ce0cbc
to
c902e63
Compare
rafiss
changed the title
knz
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @rafiss)
-- commits line 4 at r1:
"The CLI" ->
CLI commands that use a SQL connection (e.g. `cockroach sql`, `cockroach node status`, etc) now ...
ditto below
Release note (cli change): CLI commands that use a SQL connection (e.g. `cockroach sql`, `cockroach node status`, etc) now support connecting with PGPASSFILE and PGSERVICEFILE. The behavior is compatible with how libpq (the psql C library) behaves. PGPASSFILE defaults to ~/.pgpass. It is a file that contains lines in the format ``` hostname:port:database:username:password ``` The password field from the first line that matches the current connection parameters will be used to connect to the database. PGSERVICEFILE defaults to ~/.pg_service.conf. It is a file that contains lines in the format ``` [myservice] host=somehost port=26257 user=someuser ``` Any connection parameters (including passfile or password) can be specified here. Then, a connection string that specifies the `service=myservice` connection parameter will use the values in PGSERVICEFILE to connect. Release note (cli change): CLI commands that use a SQL connection (e.g. `cockroach sql`, `cockroach node status`, etc) now default to using the the file in ~/.postgresql/root.crt for the `sslrootcert` when connecting. The file can still be configured using the PGSSLROOTCERT environment variable or the `sslrootcert` URL parameter.
rafiss
commented
Jun 3, 2022
There was a problem hiding this comment.
tftr!
bors r=knz
Reviewable status:
Previously, knz (kena) wrote…
"The CLI" ->
CLI commands that use a SQL connection (e.g. `cockroach sql`, `cockroach node status`, etc) now ...ditto below
fixed
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note (cli change): The CLI now supports connecting with PGPASSFILE
and PGSERVICEFILE. The behavior is compatible with how libpq (the psql C
library) behaves.
PGPASSFILE defaults to ~/.pgpass. It is a file that contains lines in the format
The password field from the first line that matches the current connection
parameters will be used to connect to the database.
PGSERVICEFILE defaults to ~/.pg_service.conf. It is a file that contains
lines in the format
Any connection parameters (including passfile or password) can be specified here.
Then, a connection string that specifies the
service=myserviceconnectionparameter will use the values in PGSERVICEFILE to connect.
Release note (cli change): The CLI now defaults to using the the file in
~/.postgresql/root.crt for the
sslrootcertwhen connecting. The file canstill be configured using the PGSSLROOTCERT environment variable or
the
sslrootcertURL parameter.