dev: various improvements to dev generate cgo and friends
#82418
Conversation
|
This change is |
rickystewart
force-pushed
the
devgenerateimprovements
branch
2 times, most recently
from
8de43c2
to
3540d9b
Compare
1. Up until this point, `dev generate go` has not included the `zcgo_flags.go` sources, which has been a point of confusion for people who expect `dev generate go` to generate all the .go files. Now `dev generate go` includes `cgo` as well, and there is a new target `dev generate go_nocgo` that does what `dev generate go` used to do. 2. Now `dev generate cgo` is conscious of where `force_build_cdeps` is set. If it is, then we make sure not to check in one of the pre-archived locations. To this end we add a `test_force_build_cdeps` target that `dev generate cgo` builds. Release note: None
rickystewart
force-pushed
the
devgenerateimprovements
branch
from
3540d9b
to
9847968
Compare
There was a problem hiding this comment.
LGTM!! :D
Reviewed 2 of 5 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @mari-crl and @rickystewart)
pkg/cmd/dev/generate.go line 86 at r1 (raw file):
targetsMap[target] = struct{}{} } {
What's the goal of this block here and the one below? Just for style, to make it clearer that these belong together?
There was a problem hiding this comment.
Reviewable status:
|
TFTR!
The blocks just open up a new scope. In this case I have some similarly named variables between the two blocks and I don't want to accidentally reference one when I mean the other. bors r=mari-crl |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build failed (retrying...): |
|
Build succeeded: |
dev generate gohas not included thezcgo_flags.gosources, which has been a point of confusion forpeople who expect
dev generate goto generate all the .go files.Now
dev generate goincludescgoas well, and there is a newtarget
dev generate go_nocgothat does whatdev generate gousedto do.
dev generate cgois conscious of whereforce_build_cdepsisset. If it is, then we make sure not to check in one of the
pre-archived locations. To this end we add a
test_force_build_cdepstarget that
dev generate cgobuilds.Release note: None