sql: use uint32 for DOid #82430
Merged
sql: use uint32 for DOid #82430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
force-pushed
the
oid-uint32
branch
6 times, most recently
from
86a9ac1
to
f6ca7b0
Compare
This resolves a piece of tech debt that has caused us a few surprises and bugs in the past. This doesn't change anything about the on-disk representation -- it just makes it so that OIDs handled in memory are more reliably unsigned 32 bit integers. Release note: None
Release note (sql change): Casting from an integer to OID, or calling the `oid` builtin function, using an integer that is larger than 32 bits now results in an error. Specifically, the range for valid inputs is [MinInt32, MaxUint32].
Release note (sql change): An error is now returned if an OID is compared to an integer that is out of the allowable range of OID input values, which is [MinInt32, MaxUint32].
otan
approved these changes
Jun 7, 2022
|
tft! bors r=otan |
|
Build succeeded: |
This was referenced Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #41904
This resolves a piece of tech debt that has caused us a few surprises
and bugs in the past. This doesn't change anything about the on-disk
representation -- it just makes it so that OIDs handled in memory are
more reliably unsigned 32 bit integers.
Release note: None