Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: tweak newMVCCIterator() #82443

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Jun 4, 2022

This patch tweaks newMVCCIterator() for use with MVCC range
tombstones, and uses it for all appropriate MVCC operations.

Release note: None

@erikgrinaker erikgrinaker self-assigned this Jun 4, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker
Copy link
Contributor Author

This one's unblocked and ready to go now too.

Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @aliher1911, @itsbilal, and @nicktrav)

This patch tweaks `newMVCCIterator()` for use with MVCC range
tombstones, and uses it for all appropriate MVCC operations.

Release note: None
@erikgrinaker
Copy link
Contributor Author

CI failure appears unrelated.

bors r=jbowens

@craig
Copy link
Contributor

craig bot commented Jun 7, 2022

Build succeeded:

@craig craig bot merged commit 0c8f826 into cockroachdb:master Jun 7, 2022
@erikgrinaker erikgrinaker deleted the new-mvcc-iterator branch June 8, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants