Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: kvserver: allow gc of data at timestamp < lease start #82969

Merged

Conversation

irfansharif
Copy link
Contributor

@irfansharif irfansharif commented Jun 16, 2022

Backport 1/1 commits from #82956.

/cc @cockroachdb/release


Fixes #82954.

Release note (bug): Fix a bug where it was possible to accrue MVCC
garbage for much longer than needed.

Release justification: Bug fix.

Fixes cockroachdb#82954.

Release note (bug): Fix a bug where it was possible to accrue MVCC
garbage for much longer than needed.

Release justification: Bug fix.
@irfansharif irfansharif requested a review from a team as a code owner June 16, 2022 00:42
@blathers-crl
Copy link

blathers-crl bot commented Jun 16, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@irfansharif
Copy link
Contributor Author

This was an unclean backport (just re-did manually), this code changed a bit with the new PTS implementation.

@irfansharif irfansharif merged commit 1b1ae61 into cockroachdb:release-21.2 Jun 16, 2022
@irfansharif irfansharif deleted the backport21.2-82956 branch June 16, 2022 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants