Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: remove cockroach quit #82988

Merged
merged 7 commits into from
Jun 17, 2022
Merged

cli: remove cockroach quit #82988

merged 7 commits into from
Jun 17, 2022

Commits on Jun 16, 2022

  1. cli: move the RPC client code to a separate file 

    Release note: None
    @knz
    knz committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    831a3cd View commit details
    Browse the repository at this point in the history

  2. cli: move the node shutdown code to its own file 

    Release note: None
    @knz
    knz committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    4066038 View commit details
    Browse the repository at this point in the history

  3. cli: rename quitCtx to drainCtx 

    Release note: None
    @knz
    knz committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    540e83d View commit details
    Browse the repository at this point in the history

  4. roachprod: new command-line flag --max-wait 

    As of v20.1, the recommended way to shut down a node is to
send SIGTERM, then wait for the process to gracefully terminate,
then *only if it doesn't terminate within a reasonable delay* follow
up with SIGKILL.
The command `cockroach quit` was deprecated.

In order to enable graceful shutdown tests, we thus need a new
mechanism in `roachprod` to "send a signal then wait a reasonable
amount of time until the process terminates".

This patch introduces this via the new command-line flag `--max-wait`.

Release note: None
    @knz
    knz committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    db8313f View commit details
    Browse the repository at this point in the history

  5. roachtest: avoid cockroach quit to shut down nodes 

    Release note: None
    @knz
    knz committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    1835a35 View commit details
    Browse the repository at this point in the history

  6. *: remove mentions of cockroach quit 

    Release note: None
    @knz
    knz committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    ae543f7 View commit details
    Browse the repository at this point in the history

  7. cli: remove cockroach quit 

    Release note (backward-incompatible change): The `cockroach quit`
command was removed. It had been deprecated since v20.1. To shut down
a node gracefully, send a SIGTERM signal to it.
    @knz
    knz committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    903437a View commit details
    Browse the repository at this point in the history