Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: sql: unredact fields for captured index usage stats logs #83293

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

THardy98
Copy link
Contributor

@THardy98 THardy98 commented Jun 23, 2022

Backport 1/1 commits from #83136.

/cc @cockroachdb/release


Resolves: #81463

Previously, the log fields for the capture index usage stats logs were
identified as sensitive information and redacted. This change marks the
captured index usage stats log fields as not sensitive, giving us more
information to work with in our telemetry data.

Release note (sql change): Unredact fields for captured index usage
stats telemetry logs.

Release justification: Category 4: Low risk, high benefit changes to existing functionality

Previously, the log fields for the capture index usage stats logs were
identified as sensitive information and redacted. This change marks the
captured index usage stats log fields as not sensitive, giving us more
information to work with in our telemetry data.

Release note (sql change): Unredact fields for captured index usage
stats telemetry logs.
@THardy98 THardy98 requested a review from a team as a code owner June 23, 2022 18:00
@blathers-crl
Copy link

blathers-crl bot commented Jun 23, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@THardy98 THardy98 requested a review from a team June 23, 2022 18:00
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants