Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ccl: upgrade by-name sequence reference to by-ID during restore" #84308

Conversation

Xiang-Gu
Copy link
Contributor

This reverts commit f498598 because
this PR introduced some dependencies that violates certain existing
dependency assertions.

Release note: None

This reverts commit f498598 because
this PR introduced some dependencies that violates certain existing
dependency assertions.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@chengxiong-ruan chengxiong-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, assuming this is an auto revert and CI passes

@Xiang-Gu Xiang-Gu marked this pull request as ready for review July 12, 2022 21:10
@Xiang-Gu Xiang-Gu requested review from a team and dt July 12, 2022 21:10
@ajwerner
Copy link
Contributor

LGTM too

@Xiang-Gu
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 13, 2022

Build succeeded:

@craig craig bot merged commit 67ac1c3 into cockroachdb:master Jul 13, 2022
@Xiang-Gu Xiang-Gu deleted the revert_commit_upgrade_seq_reference_during_restore branch July 13, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants