Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: don't panic on Iterator.Close #84449

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Commits on Jul 14, 2022

  1. storage: don't panic on Iterator.Close

    Don't panic if Iterator.Close returns a non-nil error. Iteration errors should
    already be surfaced through (*pebble.Iterator).Error and
    (storage.EngineIterator).Valid. Panicking may crash the node for retriable,
    ephemeral I/O errors, especially when reading from sstables over the network.
    
    In a follow up, we should make sure we're still appropriately panicking for
    non-retriable errors.
    
    Fix cockroachdb#84396.
    
    Release note (bug fix): fix bug where an ephemeral I/O error could crash a
    node.
    jbowens committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    00386fe View commit details
    Browse the repository at this point in the history