Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: ui: update empty results message on SQL Activity #84623

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

maryliag
Copy link
Contributor

Backport 1/1 commits from #84494.

/cc @cockroachdb/release


Previously, when there was no data on the time interval
selected, we were displaying a message still referencing
our previous behaviour of only saving info for 1h.
This commit updates the message to remove that reference
and point out there are no data on the selected time
interval.

Before
Screen Shot 2022-07-15 at 12 00 01 PM
Screen Shot 2022-07-15 at 12 03 16 PM

After
Screen Shot 2022-07-15 at 2 10 58 PM
Screen Shot 2022-07-15 at 2 11 05 PM

Release note (ui change): Update the message when there is no
data on the selected time interval on Statement and Transaction
pages.


Release justification: low risk change

Previously, when there was no data on the time interval
selected, we were displaying a message still referencing
our previous behaviour of only saving info for 1h.
This commit updates the message to remove that reference
and point out there are no data on the selected time
interval.

Release note (ui change): Update the message when there is no
data on the selected time interval on Statement and Transaction
pages.
@maryliag maryliag requested a review from a team July 18, 2022 22:42
@blathers-crl
Copy link

blathers-crl bot commented Jul 18, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag merged commit 176afd1 into cockroachdb:release-22.1 Jul 19, 2022
@maryliag maryliag deleted the backport22.1-84494 branch July 19, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants