release-21.2: opt: don't panic on negated geospatial comparison operator #84629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #84524 on behalf of @DrewKimball.
/cc @cockroachdb/release
Previously, the
NegateComparison
rule could match geospatialcomparison operators like
~
. This would lead to a panic when therule attempted to construct the negated version of the expression,
since there is no negation for
~
and other geospatial comparisons.This patch modifies
NegateComparison
to directly checkopt.NegateOpMap
to ensure that a comparison can be negated beforematching the expression.
Fixes #84476
Release note (bug fix): Fixed a bug introduced in 20.2 that could
cause a panic when an expression contained a geospatial comparison
like
~
that was negated.Release justification: