Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ttl: split metrics into separate file #84734

Merged
merged 1 commit into from
Jul 21, 2022
Merged

ttl: split metrics into separate file #84734

merged 1 commit into from
Jul 21, 2022

Conversation

ecwall
Copy link
Contributor

@ecwall ecwall commented Jul 20, 2022

Release note: None

@ecwall ecwall requested a review from a team July 20, 2022 17:20
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ecwall
Copy link
Contributor Author

ecwall commented Jul 20, 2022 •
edited
Loading

The ttljob.go file was getting pretty large in #84728 so I decided to split it into multiple files. I pulled that part out of #84728 to make the DistSQL change easier to review.

@ecwall ecwall requested review from rafiss and otan July 21, 2022 11:18
@ecwall
Copy link
Contributor Author

ecwall commented Jul 21, 2022

bors r=otan

@craig
Copy link
Contributor

craig bot commented Jul 21, 2022

Build succeeded:

@craig craig bot merged commit ca18856 into cockroachdb:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otan otan otan approved these changes

@rafiss rafiss Awaiting requested review from rafiss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ecwall @cockroach-teamcity @otan