importer: support {} format for arrays in CSV #85850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
force-pushed
the
fix-import-csv-array
branch
2 times, most recently
from
374e1aa
to
da24c69
Compare
rafiss
force-pushed
the
fix-import-csv-array
branch
from
da24c69
to
79f5ae5
Compare
Release note (sql change): Arrays can now be imported in a CSV file
using the {} format, similar to COPY FROM. Importing array expressions
(e.g. ARRAY[1, 2, 3]) is still supported as well.
rafiss
force-pushed
the
fix-import-csv-array
branch
from
79f5ae5
to
bad5944
Compare
ecwall
approved these changes
Aug 11, 2022
| // both array expressions (like `ARRAY[1, 2, 3]`) and literals (like | ||
| // `{1, 2, 3}`). | ||
| var err2 error | ||
| conv.Datums[datumIdx], _, err2 = tree.ParseAndRequireString(conv.VisibleColTypes[i], field.Val, conv.EvalCtx) |
There was a problem hiding this comment.
It is probably outside the scope of this change, but is there a grammar that a parser can be generated from?
There was a problem hiding this comment.
you mean to avoid the fallback logic? it won't be that easy -- the difference between these two formats is that one is an expression (e.g. ARRAY[1, 2, 3 ...]) but the other is the format that arrays represented as string literals use (e.g. in {1, 2, 3 ... }::INT[]). The string literal format isn't (and i think shouldn't) be represented in our sql.y file, but it's handled in pkg/sql/sem/tree/parse_array.go
|
tftr! bors r=ecwall |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #84631
Release note (sql change): Arrays can now be imported in a CSV file
using the {} format, similar to COPY FROM. Importing array expressions
(e.g. ARRAY[1, 2, 3]) is still supported as well.