sql: prevent DROP OWNED BY with synthetic privileges #86619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
you need to implement the methods on |
RichardJCai
force-pushed
the
drop_owned_by
branch
from
9aa10aa
to
7310215
Compare
ajwerner
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
Release justification: disallowing certain case within new schema change, bug fix Release note (sql change): DROP OWNED BY cannot be performed if the user has synthetic privileges (in system.privileges)
RichardJCai
force-pushed
the
drop_owned_by
branch
from
7310215
to
2bd3826
Compare
|
Thanks for reviewing! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release justification: disallowing certain case within new schema change, bug fix
Release note (sql change): DROP OWNED BY cannot be performed if the
user has synthetic privileges (in system.privileges)
Fixes #86499