Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix array decoding in COPY #86712

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Aug 23, 2022

fixes #82792

Release note (bug fix): Fixed a bug that caused some special characters
to be misread if they were being ready by COPY ... FROM into a
TEXT[] column.

Release justification: bug fix to existing functionality.

Release note (bug fix): Fixed a bug that caused some special characters
to be misread if they were being ready by COPY ... FROM into a
TEXT[] column.

Release justification: bug fix to existing functionality.
@rafiss rafiss requested review from otan and a team August 23, 2022 21:48
@rafiss rafiss requested a review from a team as a code owner August 23, 2022 21:48
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! sorry we didn't get to it.

@rafiss
Copy link
Collaborator Author

rafiss commented Aug 24, 2022

tftr! merging since it looks like CI flakes

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 24, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 24, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 25, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 25, 2022

Build succeeded:

@craig craig bot merged commit 342fabb into cockroachdb:master Aug 25, 2022
@blathers-crl
Copy link

blathers-crl bot commented Aug 25, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 1144e7a to blathers/backport-release-21.2-86712: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.


error creating merge commit from 1144e7a to blathers/backport-release-22.1-86712: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COPY doesn't decode correctly arrays of text
3 participants