Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: opt: don't push limit with invalid ordering into window function #87746

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 9, 2022

Backport 1/1 commits from #87320 on behalf of @DrewKimball.

/cc @cockroachdb/release


This commit modifies the PushLimitIntoWindow normalization rule to
check whether the Limit ordering can be restricted to only reference
input columns, and to avoid matching if not. This prevents a panic that
would occur after pushing a Limit that references a window function
below that window function.

Fixes #69685

Release justification: low-risk fix for internal error

Release note (bug fix): Fixed a bug existing since before 21.1 that
could cause an internal error when executing a query with a limit
ordering on the output of a window function.


Release justification:

This commit modifies the `PushLimitIntoWindow` normalization rule to
check whether the `Limit` ordering can be restricted to only reference
input columns, and to avoid matching if not. This prevents a panic that
would occur after pushing a `Limit` that references a window function
below that window function.

Fixes #69685

Release justification: low-risk fix for internal error

Release note (bug fix): Fixed a bug existing since before 21.1 that
could cause an internal error when executing a query with a limit
ordering on the output of a window function.
@blathers-crl blathers-crl bot requested a review from a team as a code owner September 9, 2022 20:17
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-87320 branch from d058293 to 6a4f8e1 Compare September 9, 2022 20:17
@blathers-crl blathers-crl bot requested a review from mgartner September 9, 2022 20:17
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 9, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from msirek September 9, 2022 20:17
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 9, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@msirek msirek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @mgartner)

@DrewKimball
Copy link
Collaborator

TFTR!

@DrewKimball DrewKimball merged commit df7b9d9 into release-22.1 Sep 22, 2022
@DrewKimball DrewKimball deleted the blathers/backport-release-22.1-87320 branch September 22, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants