release-22.1: opt: don't push limit with invalid ordering into window function #87746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #87320 on behalf of @DrewKimball.
/cc @cockroachdb/release
This commit modifies the
PushLimitIntoWindow
normalization rule tocheck whether the
Limit
ordering can be restricted to only referenceinput columns, and to avoid matching if not. This prevents a panic that
would occur after pushing a
Limit
that references a window functionbelow that window function.
Fixes #69685
Release justification: low-risk fix for internal error
Release note (bug fix): Fixed a bug existing since before 21.1 that
could cause an internal error when executing a query with a limit
ordering on the output of a window function.
Release justification: