Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: ui: show app information on SQL Activity #87868

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 12, 2022

Backport 1/1 commits from #87803 on behalf of @maryliag.

/cc @cockroachdb/release


Add Application Name to:

  • Statement Overview

Screen Shot 2022-09-11 at 10 24 26 PM

  • Transaction Overview

Screen Shot 2022-09-11 at 10 24 41 PM

  • Transaction Details

Screen Shot 2022-09-11 at 10 24 52 PM

Fixes #87782
Partially Addresses #85229

Rename from "App" to "Application Name" on
Statement Details.
Screen Shot 2022-09-11 at 10 25 08 PM

Release note (ui change): Added Application Name to Statement overview, Transaction Overview (and their respective column selectors), Transaction Details. Updated label from "App" to "Application Name" on Statement Details page


Release justification: low risk, high benefit change

Add Application Name to:
- Statement Overview
- Transaction Overview
- Transaction Details
and their respective column selectors.

Fixes #87782
Partially Addresses #85229

Rename from "App" to "Application Name" on
Statement Details.

Release note (ui change): Add Application Name to
Statement overview, Transaction Overview (and their respective
column selectors), Transaction Details. Update label
from "App" to "Application Name" on Statement Details
page.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-87803 branch from 188ac88 to ce185fb Compare September 12, 2022 19:32
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 12, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 12, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag requested a review from a team September 12, 2022 20:13
Copy link
Contributor

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maryliag maryliag merged commit 2b9ed3b into release-22.2 Sep 12, 2022
@maryliag maryliag deleted the blathers/backport-release-22.2-87803 branch September 12, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants