-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: sql: support #typeHints
greater than #placeholders
for prepare stmt
#88146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous, we only support pgwire prepare stmt with the number of typehints equal or smaller than the number of the placeholders in the query. E.g. the following usage are not supported: ``` Parse {"Name": "s2", "Query": "select $1", "ParameterOIDs":[1043, 1043, 1043]} ``` Where there are 1 placeholder in the query, but 3 type hints. This commit is to allow mismatching #typeHints and #placeholders. The former can be larger than the latter now. Release justification: Low risk, high benefit changes to existing functionality Release note (sql change): For pgwire-level prepare statements, support the case where the number of the type hints is greater than the number of placeholders in the given query.
blathers-crl
bot
force-pushed
the
blathers/backport-release-22.2-87535
branch
from
September 19, 2022 16:28
c133023
to
c713cff
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Sep 19, 2022
rafiss
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! can you post a request in #release-backports
for this?
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #87535 on behalf of @ZhouXing19.
/cc @cockroachdb/release
Previous, we only support pgwire prepare stmt with the number of typehints equal or smaller than the number of the placeholders in the query. E.g. the following usage are not supported:
Where there is 1 placeholder in the query, but 3 type hints.
This commit is to allow mismatching #typeHints and #placeholders. The former can be larger than the latter now.
This feature is needed for CRDB's support for Hasura GraphQL Engine.
Release justification: Low risk, high benefit changes to existing functionality
Release note: For pgwire-level prepare statements, add support for the case where the number of the type hints is greater than the number of placeholders in the given query.
Release justification: