Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/schemachanger: plumb context, check for cancelation sometimes #88471

Merged
merged 1 commit into from Sep 23, 2022
Merged

sql/schemachanger: plumb context, check for cancelation sometimes #88471

merged 1 commit into from Sep 23, 2022

Conversation

ajwerner
Copy link
Contributor

Fixes #87246

This will also improve tracing.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ajwerner ajwerner force-pushed the ajwerner/context-plumbing-in-schema-changer branch 2 times, most recently from 5aa6d78 to 2d9edcb Compare September 22, 2022 17:12
@ajwerner ajwerner marked this pull request as ready for review September 22, 2022 17:12
@ajwerner ajwerner requested a review from a team as a code owner September 22, 2022 17:12
@ajwerner ajwerner requested a review from a team September 22, 2022 17:12
postamar
postamar approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense.

@ajwerner ajwerner added the backport-22.2.x Flags PRs that need to be backported to 22.2. label Sep 22, 2022
@ajwerner
sql/schemachanger: plumb context, check for cancelation sometimes
8778f63 
Fixes cockroachdb#87246

This will also improve tracing.

Release note: None
@ajwerner ajwerner force-pushed the ajwerner/context-plumbing-in-schema-changer branch from 2d9edcb to 8778f63 Compare September 23, 2022 16:06
@ajwerner
Copy link
Contributor Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 23, 2022

Build succeeded:

@craig craig bot merged commit 2c18ed3 into cockroachdb:master Sep 23, 2022
@blathers-crl blathers-crl bot mentioned this pull request Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postamar postamar postamar approved these changes

Assignees
No one assigned
Labels
backport-22.2.x Flags PRs that need to be backported to 22.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sql/schemachanger: check the context periodically when planning
3 participants
@ajwerner @cockroach-teamcity @postamar