Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: route admission prs to targeted github team #88486

Merged
merged 1 commit into from
Sep 23, 2022
Merged

github: route admission prs to targeted github team #88486

merged 1 commit into from
Sep 23, 2022

Conversation

irfansharif
Copy link
Contributor

Release note: None

@irfansharif irfansharif requested a review from a team September 22, 2022 18:03
@cockroach-teamcity
Copy link
Member

This change is Reviewable

sumeerbhola
sumeerbhola approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber-stamping. Thanks for doing this!

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @irfansharif)

@irfansharif
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 23, 2022

Build succeeded:

@craig craig bot merged commit 8c2b247 into cockroachdb:master Sep 23, 2022
@irfansharif irfansharif deleted the 220920.admission-code-owners branch September 23, 2022 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumeerbhola sumeerbhola sumeerbhola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@irfansharif @cockroach-teamcity @sumeerbhola