testserver: add ShareMostTestingKnobsWithTenant option #88557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new ShareMostTestingKnobs copies nearly all of the testing knobs specified for a TestServer to any tenant started for that server. The goal here is to make it easier to write tests that depend on testing hooks that work under probabilistic tenant testing. Release justification: non-production code change Release note: None
stevendanna
requested review from
herkolategan
and removed request for
a team
|
This change is |
msbutler
approved these changes
Sep 23, 2022
|
@msbutler Mostly I just didn't want to cause instability elsewhere right now. I figured we can use this in backupccl for a bit to unblock your efforts and then I can try making it the default on master. |
|
bors r=msbutler |
|
Build succeeded: |
|
Another vote for sharing by default :-). Turns out I should have gotten my act together and put this out for review yesterday. Unfortunately, it was on my backlog for a long time. If there are no objections (@stevendanna), I can merge mine next week and pull out the "maybe" behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new ShareMostTestingKnobs copies nearly all of the testing knobs specified for a TestServer to any tenant started for that server.
The goal here is to make it easier to write tests that depend on testing hooks that work under probabilistic tenant testing.
Release justification: non-production code change
Release note: None