bench: add a benchmark for update with assigment casts #88615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzefovich
added
backport-22.1.x
|
This change is |
mgartner
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @mgartner and @yuzefovich)
pkg/bench/bench_test.go line 602 at r1 (raw file):
buf.Reset() buf.WriteString(`UPDATE bench.update SET v = v + `) buf.WriteString(`CASE WHEN k < 500 THEN 1.0 ELSE 2.0 END `)
nit: you don't need the CASE to force an assignment cast. This will do the trick: update t set v = (v + 1.0)::FLOAT where ...
Release note: None
yuzefovich
force-pushed
the
update-bench
branch
from
4b062a8
to
6dab55f
Compare
yuzefovich
commented
Sep 26, 2022
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
|
Build succeeded: |
This was referenced Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs: #88525.
Release note: None