release-22.1: sql: cluster setting for persisting gateway node ID #88634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #88583.
/cc @cockroachdb/release
When persisting statement statistics, one of the columns is the gateway node id, but because it needs to be a unique value, users who have a large amount of data are creating a lot of rows on the system.statement_statistics table.
To help decrease the amount of rows, the new cluster setting
sql.metrics.statement_details.gateway_node.enabled
define if the value on that column should be the gateway node ID or 0. We still display the node ID on the statistics column.Fixes #88484
Release note (sql change): New cluster setting
sql.metrics.statement_details.gateway_node.enabled
that controls if the gateway node ID should be persisted to thesystem.statement_statistics
table as is or as a 0, to decrease cardinality on the table. The node id is still available on the statistics column.Release justification: low risk, high benefit change