Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: sql: only record index reads on non-internal sessions #88943

Merged
merged 1 commit into from Sep 29, 2022

Conversation

THardy98
Copy link
Contributor

@THardy98 THardy98 commented Sep 28, 2022

Backport 1/1 commits from #88756.

/cc @cockroachdb/release


Resolves: #77598

Previously, explicit CREATE INDEX queries were causing unintended index reads in our index_usage_statistics subsystem. The unintended index reads were caused by an index validation query from an internal executor that did not use an internal planner. However, the internal executor does set its session data as internal. This change adds a check to only record index reads when the planner is not internal AND the session is not internal.

Release note (bug fix): Fixed unintended recordings of index reads caused by internal executor/queries.

Release justification: low risk, high benefit changes to existing functionality

@THardy98 THardy98 requested a review from a team as a code owner September 28, 2022 18:26
@blathers-crl
Copy link

blathers-crl bot commented Sep 28, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@THardy98 THardy98 removed the request for review from a team September 28, 2022 18:26
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure tests are passing, otherwise :lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

Resolves: cockroachdb#77598

Previously, explicit `CREATE INDEX` queries were causing unintended
index reads in our `index_usage_statistics` subsystem. The unintended
index reads were caused by an index validation query from an internal
executor that did not use an internal planner. However, the internal
executor does set its session data as internal. This change adds a check
to only record index reads when the planner is not internal AND the
session is not internal.

Release note (bug fix): Fixed unintended recordings of index reads
caused by internal executor/queries.
@THardy98 THardy98 merged commit c7b333b into cockroachdb:release-22.1 Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants