release-22.2: ui: fix bug that set node ids to undefined on advanced debug #89197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
An earlier change to async load the base ui data broke the assumption this page makes that the data is available at the time the JS is loaded. Now the call to get the init data is done inside the `render()` method of the component which is awaits the UI data at the top level. Resolves #83623 Release note (ui change): fixed a bug that prevented usage of profiling links on the Advanced Debug page.
blathers-crl
bot
force-pushed
the
blathers/backport-release-22.2-88603
branch
from
473b462
to
dbd1eca
Compare
blathers-crl
bot
added
blathers-backport
|
This change is |
aadityasondhi
approved these changes
Oct 3, 2022
nkodali
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #88603 on behalf of @dhartunian.
/cc @cockroachdb/release
An earlier change to async load the base ui data broke the assumption this page makes that the data is available at the time the JS is loaded. Now the call to get the init data is done inside the
render()method of the component which is awaits the UI data at the top level.Resolves #83623
Release note (ui change): fixed a bug that prevented usage of profiling links on the Advanced Debug page.
Release justification: