release-22.2: norm: do not fold floor division with unit denominator #89262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #87808.
/cc @cockroachdb/release
Fixes #87605
The floor division operator
//
is like division but drops thefractional portion of the result. Normalization rule FoldDivOne
rewrites
(column // 1)
as(column)
which is incorrect if thedata in
column
has fractional digits, as those digits should bedropped.
The solution is to only fold
(column // 1)
whencolumn
is one ofthe integer types.
Release note (bug fix): This patch fixes incorrect results from
the floor division operator,
//
, when the numerator is non-constantand the denominator is the constant 1.
Release justification: low risk fix for incorrect results on divide by 1