release-22.2.0: upgrades: add migration to remove corrupt userfile fk constraint #89370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #88878.
/cc @cockroachdb/release
In previous releases, userfiles would create broken tables because
of incorrect use of the internal executor. As a result, any user that
has used userfile, would fail the 22.2 upgrade precondition check.
This does 2 things:
1 allows the precondition to pass even in the presence of an invalid
object as long as that object is very likely the userfile payload table.
Adds a new migration that removes the foreign key mutation for userfile
payload tables.
We determine whether something is a "userfile payload table" by checking
its name, the column names, the column types, the name of the referenced table,
the column names of the referenced table, and the column types of the referenced table.
Release justification: Avoid having a failed upgrade for every user of
userfile.