Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2.0: upgrades: add migration to remove corrupt userfile fk constraint #89370

Merged

Conversation

stevendanna
Copy link
Collaborator

Backport 1/1 commits from #88878.

/cc @cockroachdb/release


In previous releases, userfiles would create broken tables because
of incorrect use of the internal executor. As a result, any user that
has used userfile, would fail the 22.2 upgrade precondition check.

This does 2 things:

  • 1 allows the precondition to pass even in the presence of an invalid
    object as long as that object is very likely the userfile payload table.

  • Adds a new migration that removes the foreign key mutation for userfile
    payload tables.

We determine whether something is a "userfile payload table" by checking
its name, the column names, the column types, the name of the referenced table,
the column names of the referenced table, and the column types of the referenced table.

Release justification: Avoid having a failed upgrade for every user of
userfile.

The related job for this FK constraint was never created because of a
userfile error. This migration removes the constraint since it is not
currently needed.

Release justification: Avoid having a failed upgrade for every user of
userfile.

Release note (bug fix): Fixes tables created by userfile storage that
have invalid foreign key constraints.
@stevendanna stevendanna requested a review from a team October 5, 2022 09:46
@stevendanna stevendanna requested a review from a team as a code owner October 5, 2022 09:46
@blathers-crl
Copy link

blathers-crl bot commented Oct 5, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@stevendanna stevendanna changed the title release-22.2.0: upgrades: skip known userfile-related corruption in desc validation release-22.2.0: upgrades: add migration to remove corrupt userfile fk constraint Oct 5, 2022
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this

@stevendanna stevendanna merged commit 7205bde into cockroachdb:release-22.2.0 Oct 7, 2022
@stevendanna stevendanna deleted the backport22.2.0-88878 branch October 7, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants