release-22.2.0: opt: fix WithScan errors in apply-joins

[blathers-crl]

Backport 1/1 commits from #89830 on behalf of @mgartner.

/cc @cockroachdb/release

---

In #88396, we updated the planning logic for the RHS of apply-joins so that all With expressions in the original memo's metadata are added to the metadata of the new, temporary memo. This change was brittle. It relied on the memo's curWithID to enumerate all With expressions in the metadata, but it did not propagate the same curWithID to the new temporary memo. This caused internal errors with nested apply-joins, because the With expression would not propagate to the inner-most memo's metadata.

This commit fixes the issue by removing the dependence on curWithID, and directly iterating over all With expressions to add them to the new metadata for the RHS of apply-joins.

Fixes #89601

Release note (bug fix): A bug has been fixed that caused internal errors in rare cases when running CTEs (statements with WITH clauses). This bug is only present in v22.2.0-beta.2, v22.2.0-beta.3, v21.2.16, and v22.1.9.

---

Release justification: Fixes recent regression in apply-join planning.

[blathers-crl]

Thanks for opening a backport.

Please check the backport criteria before merging:

• Patches should only be created for serious issues or test-only changes.
• Patches should not break backwards-compatibility.
• Patches should change as little code as possible.
• Patches should not change on-disk formats or node communication protocols.
• Patches should not add new functionality.
• Patches must not add, edit, or otherwise modify cluster versions; or add version gates.

If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.

• There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
• The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
• New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
• The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

• What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
• Will this work in a cluster of mixed patch versions? Did we test that?
• If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

[cockroach-teamcity]

This change is 

[DrewKimball]

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @michae2 and @msirek)

[msirek]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! 2 of 0 LGTMs obtained (waiting on @michae2)

[rytaft]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! 3 of 0 LGTMs obtained (waiting on @michae2)