Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: changefeedccl: flush to sink before initial_scan_only completion #90277

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 19, 2022

Backport 1/1 commits from #90241 on behalf of @samiskin.

/cc @cockroachdb/release


Resolves #90146

Previously if a changefeed was started with initial_scan_only, the job would be completed as soon as a resolved event was seen by the kv_feed even though we may not have flushed the messages to the sink yet. This could result in a huge difference where an initial_scan_only changefeed on a 100000 row table could complete successfully with a kafka topic only seeing <2000 messages. A similar issue of missing messages would also occur with schema_change_policy='stop', though the changefeed is marked failed in that case.

This change ensures the changefeed drains the eventProducer and sink upon a normal kvfeed exit.

This also uncovered a bug in the chunked_event_queue where empty() could return true even if there were many remaining messages due to the first chunk being empty but there still being future chunks.

Release note (bug fix): initial_scan_only changefeeds now ensure that all messages have successfully flushed to the sink prior to completion instead of potentially missing messages.


Release justification: high priority and very low risk bug fix

Previously if a changefeed was started with initial_scan_only, the job
would be completed as soon as a resolved event was seen by the kv_feed
even though we may not have flushed the messages to the sink yet.  This
could result in a huge difference where an initial_scan_only changefeed
on a 100000 row table could complete successfully with a kafka topic
only seeing <2000 messages.  A similar issue of missing messages would
also occur with schema_change_policy='stop', though the changefeed is
marked failed in that case.

This was due to a bug in the chunked_event_queue where empty() could
return true even if there were many remaining messages due to the first
chunk being empty but there still being future chunks.

Release note (bug fix): initial_scan_only changefeeds now ensure that
all messages have successfully flushed to the sink prior to completion
instead of potentially missing messages.
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 19, 2022 19:27
@blathers-crl blathers-crl bot requested review from stevendanna and removed request for a team October 19, 2022 19:27
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-90241 branch from f311ee8 to feb22af Compare October 19, 2022 19:27
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 19, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 19, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@samiskin samiskin merged commit ed1d8f5 into release-22.2 Oct 19, 2022
@samiskin samiskin deleted the blathers/backport-release-22.2-90241 branch October 19, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants